Skip to content

Disable secrets-outside-env audit#3823

Merged
martincostello merged 1 commit intomasterfrom
disable-secrets-outside-env
Mar 9, 2026
Merged

Disable secrets-outside-env audit#3823
martincostello merged 1 commit intomasterfrom
disable-secrets-outside-env

Conversation

@martincostello
Copy link
Collaborator

This isn't appropriate in most cases as there's no logical environment, and environments are already used in cases where they are.

This isn't appropriate in most cases as there's no logical environment, and environments are already used in cases where they are.
Copilot AI review requested due to automatic review settings March 9, 2026 11:32
@martincostello martincostello enabled auto-merge (squash) March 9, 2026 11:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s zizmor configuration to disable the secrets-outside-env audit, aiming to avoid findings in workflows that don’t have a meaningful GitHub “environment”.

Changes:

  • Disable the secrets-outside-env zizmor rule in the repo-level config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.93%. Comparing base (b03fdec) to head (cf17ffa).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3823   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         111      111           
  Lines        3886     3886           
  Branches      784      784           
=======================================
  Hits         3689     3689           
  Misses        197      197           
Flag Coverage Δ
Linux 94.93% <ø> (ø)
Windows 94.93% <ø> (ø)
macOS 94.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello merged commit 95b24f9 into master Mar 9, 2026
18 checks passed
@martincostello martincostello deleted the disable-secrets-outside-env branch March 9, 2026 11:42
This was referenced Mar 10, 2026
This was referenced Mar 16, 2026
hwinther pushed a commit to hwinther/test that referenced this pull request Mar 16, 2026
Updated
[swashbuckle.aspnetcore.cli](https://github.com/domaindrivendev/Swashbuckle.AspNetCore)
from 10.1.4 to 10.1.5.

<details>
<summary>Release notes</summary>

_Sourced from [swashbuckle.aspnetcore.cli's
releases](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)._

## 10.1.5

## What's Changed

* Bump swagger-ui-dist from 5.31.1 to 5.32.0 in
/src/Swashbuckle.AspNetCore.SwaggerUI by @​dependabot in
domaindrivendev/Swashbuckle.AspNetCore#3814
* Migrate to actions/attest by @​martincostello in
domaindrivendev/Swashbuckle.AspNetCore#3815
* Disable secrets-outside-env audit by @​martincostello in
domaindrivendev/Swashbuckle.AspNetCore#3823
* Update zizmor to 1.23.1 by @​martincostello in
domaindrivendev/Swashbuckle.AspNetCore#3825
* Fix null examples by @​jgarciadelanoceda in
domaindrivendev/Swashbuckle.AspNetCore#3803
* Bump dependencies by @​martincostello in
domaindrivendev/Swashbuckle.AspNetCore#3835

**Full Changelog**:
domaindrivendev/Swashbuckle.AspNetCore@v10.1.4...v10.1.5


Commits viewable in [compare
view](domaindrivendev/Swashbuckle.AspNetCore@v10.1.4...v10.1.5).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=swashbuckle.aspnetcore.cli&package-manager=nuget&previous-version=10.1.4&new-version=10.1.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants